Bug 2052694: ShadowBugs extension breaks checksetup.pl --no-database by doing database operations during template initialization#164
Merged
Conversation
…by doing database operations during template initialization
mrenvoize
approved these changes
Jul 10, 2026
mrenvoize
left a comment
mrenvoize
left a comment
Contributor
There was a problem hiding this comment.
Looks good and works well..
Might be worth implementing the same change to extensions/Webhooks/Extension.pm ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
See comment 1 on the referenced bug.
Additional info
Test Plan
docker compose build --no-cacheThe error happens during the build phase so if the build succeeds, the patch fixed it. You can try the above without this patch to see it fail.